Check for invalid usage of gl_WorkGroupSize components#4181
Merged
jeremy-lunarg merged 1 commit intoKhronosGroup:mainfrom Mar 10, 2026
Merged
Check for invalid usage of gl_WorkGroupSize components#4181jeremy-lunarg merged 1 commit intoKhronosGroup:mainfrom
jeremy-lunarg merged 1 commit intoKhronosGroup:mainfrom
Conversation
The check for usage of gl_WorkGroupSize before a local_size_[xyz] declaration was not being hit in cases of access to a component because those usages get constant folded just as they are being parsed. This change adds a check before the call to foldSwizzle() to catch these cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The check for usage of gl_WorkGroupSize before a local_size_[xyz] declaration was not being hit in cases of access to a component because those usages get constant folded just as they are being parsed. This change adds a check before the call to foldSwizzle() to catch these cases.
Apparently the test suite had a couple of cases that weren't following this rule so those get updated as well.
Fixes #2627