HLSL: provide string error context only if token is a string#4183
Merged
jeremy-lunarg merged 1 commit intoKhronosGroup:mainfrom Mar 10, 2026
Merged
HLSL: provide string error context only if token is a string#4183jeremy-lunarg merged 1 commit intoKhronosGroup:mainfrom
jeremy-lunarg merged 1 commit intoKhronosGroup:mainfrom
Conversation
Some parse errors provide the token string as context. In some cases the most recent token might not be a string at all. In those cases, provide an empty string instead, rather than trying to read a corrupted pointer in the union. Bug: crbug.com/247877918
Contributor
Author
|
I've misconfigured the Google bots for ubuntu clang and gcc. stay tuned |
Contributor
Author
|
I'm having trouble with the GN builder. Please ignore that failure |
jeremy-lunarg
approved these changes
Mar 10, 2026
Contributor
Author
|
I just found out the GN build flow was never enabled on our side; I did a rewrite of the configs and accidentally enabled it. It never worked (!) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some parse errors provide the token string as context. In some cases the most recent token might not be a string at all. In those cases, provide an empty string instead, rather than trying to read a corrupted pointer in the union.
Bug: crbug.com/247877918