Skip to content

Add support for SPV_KHR_constant_data and SPV_KHR_abort#4196

Open
Samsung-CraigG wants to merge 8 commits intoKhronosGroup:mainfrom
Samsung-CraigG:cgraham/khr_shader_abort
Open

Add support for SPV_KHR_constant_data and SPV_KHR_abort#4196
Samsung-CraigG wants to merge 8 commits intoKhronosGroup:mainfrom
Samsung-CraigG:cgraham/khr_shader_abort

Conversation

@Samsung-CraigG
Copy link
Copy Markdown

Used by VK_KHR_shader_abort / VK_KHR_shader_constant_data

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Mar 23, 2026

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 3 committers have signed the CLA.

✅ Samsung-CraigG
❌ lordalcol
❌ Zhou, Shaochi(AMD)


Zhou, Shaochi(AMD) seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Samsung-CraigG
Copy link
Copy Markdown
Author

Mirrors gitlab PR#141.

@Samsung-CraigG Samsung-CraigG changed the title Add support for SPV_KHR_constant_data and SPV_KHR_abortHide local variables Add support for SPV_KHR_constant_data and SPV_KHR_abort Mar 23, 2026
@arcady-lunarg
Copy link
Copy Markdown
Contributor

@Samsung-CraigG You're going to need to fix the CI failure before this can be merged.

@Samsung-CraigG
Copy link
Copy Markdown
Author

@arcady-lunarg done (sorry, hadn't noticed as Shaochi @ AMD wrote the code & I'd not tried a GCC build)

@jeremy-lunarg
Copy link
Copy Markdown
Contributor

@Samsung-CraigG Can you ask the other authors to sign the CLA.

@ShchchowAMD
Copy link
Copy Markdown
Contributor

Hi, this is Shaochi, and this is my account for open-source commit submission.
Looks like the above account can't be used to contribute outside so I can't sign CLA directly here.
Should I re-create a new PR from this account or other steps I should follow to let this work now?

@Samsung-CraigG
Copy link
Copy Markdown
Author

I've just been discussing this with Ralph (as there seems to be a process issue here). If @ShchchowAMD has time to squish & re-submit this PR that'd be great for this instance.

(we can discuss internally at Khronos ways to avoid this next time around)

@arcady-lunarg
Copy link
Copy Markdown
Contributor

I don't think you need to create a new PR but you do need to create a new branch with commits that have the appropriate author emails. The CLA bot ultimately goes off the emails in the author field in the commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants