Add support for SPV_KHR_constant_data and SPV_KHR_abort#4196
Add support for SPV_KHR_constant_data and SPV_KHR_abort#4196Samsung-CraigG wants to merge 8 commits intoKhronosGroup:mainfrom
Conversation
|
Zhou, Shaochi(AMD) seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
Mirrors gitlab PR#141. |
|
@Samsung-CraigG You're going to need to fix the CI failure before this can be merged. |
|
@arcady-lunarg done (sorry, hadn't noticed as Shaochi @ AMD wrote the code & I'd not tried a GCC build) |
|
@Samsung-CraigG Can you ask the other authors to sign the CLA. |
|
Hi, this is Shaochi, and this is my account for open-source commit submission. |
|
I've just been discussing this with Ralph (as there seems to be a process issue here). If @ShchchowAMD has time to squish & re-submit this PR that'd be great for this instance. (we can discuss internally at Khronos ways to avoid this next time around) |
|
I don't think you need to create a new PR but you do need to create a new branch with commits that have the appropriate author emails. The CLA bot ultimately goes off the emails in the author field in the commits. |
Used by VK_KHR_shader_abort / VK_KHR_shader_constant_data