This repository was archived by the owner on May 9, 2023. It is now read-only.
Open
Conversation
|
Please follow the issue template. |
Author
|
This is an upgrade of the existing QFP square wizard. |
sethhillbrand
suggested changes
Jul 3, 2020
Collaborator
sethhillbrand
left a comment
sethhillbrand
left a comment
There was a problem hiding this comment.
This looks generally good. The only comments are inconsistencies in the formatting. We don't have a fixed Python style but we do need to be consistent within the file.
| array = PA.PadLineArray(v_pad, pads_per_row, pad_pitch, False, pin1Pos) | ||
| array.SetFirstPadInArray(pads_per_row + 1) | ||
| array = PA.PadLineArray(v_pad, pads_per_col, pad_pitch, False, pin1Pos) | ||
| array.SetFirstPadInArray( pads_per_row + 1) |
Collaborator
There was a problem hiding this comment.
Need to stay consistent in spacing
| array = PA.PadLineArray(h_pad, pads_per_row, -pad_pitch, True, | ||
| pin1Pos) | ||
| array.SetFirstPadInArray(2*pads_per_row + 1) | ||
| array.SetFirstPadInArray( pads_per_row + pads_per_col + 1) |
Collaborator
There was a problem hiding this comment.
Extra space at start
| array = PA.PadLineArray(v_pad, pads_per_col, -pad_pitch, False, | ||
| pin1Pos) | ||
| array.SetFirstPadInArray(3*pads_per_row + 1) | ||
| array.SetFirstPadInArray( 2*pads_per_row + pads_per_col + 1) |
Collaborator
There was a problem hiding this comment.
Extra space at start and missing spaces around '*'.
| sizex = (right_edge + cmargin) * 2 | ||
| sizey = (bottom_edge + cmargin) * 2 | ||
| self.draw.SetLayer( pcbnew.F_CrtYd ) | ||
| sizex = ( right_edge + cmargin ) * 2 |
Collaborator
There was a problem hiding this comment.
Don't add extra spaces here unless you are going to be consistent with them through the file.
Collaborator
|
ping @bigrom26 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace this line with your commit message! Please provide a description of your pull request
Thanks for creating a pull request to contribute to the KiCad footprint wizards! To speed up integration of your PR, please check the following items: