This repository was archived by the owner on Oct 2, 2020. It is now read-only.
Check symbol for duplicate graphic elements (#37)#303
Open
cpresser wants to merge 3 commits intoKiCad:masterfrom
Open
Check symbol for duplicate graphic elements (#37)#303cpresser wants to merge 3 commits intoKiCad:masterfrom
cpresser wants to merge 3 commits intoKiCad:masterfrom
Conversation
Introduce new rule S3.9 to check if the symbol has duplicate graphical elements.
Collaborator
|
The new rule S3.9 would need to be added to the website. Please open a pull request over at the website repo (still on github as far as i know) and link between the two |
Contributor
Author
|
Here is the PR for the website: KiCad/kicad-website#475 |
poeschlr
suggested changes
Mar 4, 2020
Replace C-Style code with more pythonic variants Rename variables Use better string-formating
Contributor
Author
|
Thanks for the review, those were all valid points with really help full recommendations. 👍 |
Contributor
Author
|
The Website-Merge-Request now lives here: https://gitlab.com/kicad/services/kicad-website/-/merge_requests/475 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce new rule S3.9 to check if the symbol has duplicate graphical elements.
This implements the 'SIMPLE' approach mentioned here:
See #37
So far there is no 'written' Rule for KLC yet. If there is some positive feedback for this patch, I can create a PR for that as well.