Skip to content
This repository was archived by the owner on Oct 2, 2020. It is now read-only.

Comments

Create Transistor_IGBT_Module lib#2773

Open
aris-kimi wants to merge 24 commits intoKiCad:masterfrom
aris-kimi:igbt_modules
Open

Create Transistor_IGBT_Module lib#2773
aris-kimi wants to merge 24 commits intoKiCad:masterfrom
aris-kimi:igbt_modules

Conversation

@aris-kimi
Copy link
Collaborator

@aris-kimi aris-kimi commented May 31, 2020

Also addition of:
STGIPS10C60-H https://www.st.com/resource/en/datasheet/stgips10c60-h.pdf
STGIPS10K60A https://www.st.com/resource/en/datasheet/stgips10k60a.pdf
STGIPS10K60A2 https://www.st.com/resource/en/datasheet/stgips10k60a.pdf
STGIPS10K60T https://www.st.com/resource/en/datasheet/stgips10k60t.pdf
STGIPS14K60 https://www.st.com/resource/en/datasheet/stgips14k60.pdf
STGIPS14K60T https://www.st.com/resource/en/datasheet/stgips14k60t.pdf
STGIPS20K60 https://www.st.com/resource/en/datasheet/stgips20k60.pdf

This PR is after Issue: #2768

Footprint PR: KiCad/kicad-footprints#2302

stgips

All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the symbol(s) you are contributing
  • Provide a screenshot of the symbol(s) from the symbol editor with the pin types visible
  • Ensure that the associated footprints match the official footprint library
    • A new fitting footprint must be submitted if the library does not yet contain one.
  • If there are matching footprint PRs, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

Be patient, we maintainers are volunteers with limited time and need to check your contribution against the datasheet. You can speed up the process by providing all the necessary information (see above). And you can speed up the process even more by providing additional info like the screenshot of the symbol editor pin table (or for high pin counts converted to csv) sorted in the same way as the pin table in the datasheet and a direct link to the datasheet page that contains the pin table.

@myfreescalewebpage myfreescalewebpage added Addition Adds new symbols to library Pending footprint Pending footprint acceptance before merging Pending reviewer A pull request waiting for a reviewer labels Jun 3, 2020
@myfreescalewebpage
Copy link
Collaborator

You wrote on the other PR:

Same with the footprint PR, second try for addition of IGBT_Module library, with some other symbols only from infineon (previous PR has only some from ST).
I would like to ask any reviewer to give priority to this one over the other.

Do you think this one should be reviewed now ?

Joel

@aris-kimi aris-kimi mentioned this pull request Aug 25, 2020
6 tasks
@aris-kimi
Copy link
Collaborator Author

At the time i wrote that i wasn't aware for libs transition. As a symbol is this one i think it is ready yes. Thank you.

@myfreescalewebpage myfreescalewebpage self-assigned this Aug 25, 2020
@myfreescalewebpage myfreescalewebpage removed the Pending reviewer A pull request waiting for a reviewer label Aug 25, 2020
@myfreescalewebpage
Copy link
Collaborator

myfreescalewebpage commented Aug 25, 2020

STGIPS10C60-H

  • Footprint filter: ST*SDIP*
  • No special character in the lib, please remove "TM" in the keywords

STGIPS10K60A

  • Footprint filter: ST*SDIP*
  • No special character in the lib, please remove "TM" in the keywords

STGIPS14K60T

  • Footprint filter: ST*SDIP*
  • No special character in the lib, please remove "TM" in the keywords
  • Name of pin 15 is ~SD

STGIPS20K60

  • Footprint filter: ST*SDIP*
  • No special character in the lib, please remove "TM" in the keywords

Cheers,
Joel

@myfreescalewebpage
Copy link
Collaborator

@aris-kimi the fp filter is still not correct. The leading "*" is not required.

fix fp filter
@aris-kimi
Copy link
Collaborator Author

totaly missed that... !!! those ft filters.. Fixed now

@myfreescalewebpage
Copy link
Collaborator

Just need to wait the footprint now.

@aris-kimi
Copy link
Collaborator Author

Thank you!!

@myfreescalewebpage
Copy link
Collaborator

@aris-kimi I wonder if this PR should not go in "IGBT_Module" too, like the other one. What do you think ?

@aris-kimi
Copy link
Collaborator Author

aris-kimi commented Sep 30, 2020

I am sorry i missunderstood. I chose to rename IGBT_Module lib to Transistor_IGBT_Module. Both symbol and footprint libs.
And i am going to rename and the other PR, but i feel its footprint is not going to get merged today, but i think this one might.. If you want to help with this please.
No design changes made here. Only footprint's lib value and file names.

@aris-kimi aris-kimi changed the title Create IGBT_Module lib Create Transistor_IGBT_Module lib Sep 30, 2020
@myfreescalewebpage
Copy link
Collaborator

When we will be on GitLab I think

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Addition Adds new symbols to library Pending footprint Pending footprint acceptance before merging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants