This repository was archived by the owner on Oct 2, 2020. It is now read-only.
SPF5122Z RF ampllifier#2870
Open
chmorgan wants to merge 2 commits intoKiCad:masterfrom
chmorgan:spf5122z
Open
Conversation
Collaborator
|
Hi @chmorgan , thanks for contributing, A few comments I have during my review:
Cheers, |
… add 'DFN-8' to description
Collaborator
Author
|
Hi @myfreescalewebpage. Thanks for yet another review! I fixed the footprint filter, keywords case and added the package to the description. As this is a high frequency RF part I've been assuming that the mfg footprint recommendations were the best way to achieve performance. Even though 3 and 6 are NC pins the mfg recommends tying them together with the adjacent pins as I've done. See the two below images cut from the datasheet: |
Collaborator
|
Hi @chmorgan with pleasure :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Datasheet: https://www.qorvo.com/products/d/da001904
Footprint pull request: KiCad/kicad-footprints#2368
All contributions to the kicad library must follow the KiCad library convention
Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:
Be patient, we maintainers are volunteers with limited time and need to check your contribution against the datasheet. You can speed up the process by providing all the necessary information (see above). And you can speed up the process even more by providing additional info like the screenshot of the symbol editor pin table (or for high pin counts converted to csv) sorted in the same way as the pin table in the datasheet and a direct link to the datasheet page that contains the pin table.