Skip to content

Conversation

@thatkookooguy
Copy link
Member

Change Summary

  • change short synopsis I [resolves #00]

    additional info about this mission

  • change short synopsis II (mission without additional info)

  • change short synopsis III

More info

(Free text here with additional photos, wikis, and additional needed information)

⚠️ MAKE SURE TO GO THROUGH THIS LIST ⚠️

(reviewers _shouldn't approve a PR without the next three checkboxs checked_)

Before you submit a PR, make sure you did the following things:

  • did you link this PR to an issue?

Make sure there's an issue open about the change you did (open one if there isn't). link this PR to that issue by writing resolves #{{issue_number}}. If this PR had several mission, link each issue in its parallel mission.

  • did you lint your changes to both javascript and scss?

hound can be pretty rough at keeping our code clean and readable! make sure you format your code by running either gulp format or gulp lint and cleaning out all the _lint errors. If you won't, you'll have a _long conversation with hound :-)

  • "I'm pretty sure I'll be able to read and understand this PR, even if I wasn't the author." - _said the PR author_

@thatkookooguy thatkookooguy temporarily deployed to kibibit-demo-pr-194 August 18, 2016 16:07 Inactive
return $q.reject(response);
};
return interceptorFactory;
}); No newline at end of file

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing line feed at file end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants