Revised error handling and simplified message output options. #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…(err, msg) Revised message handling to ensure the original message is returned un-changed. Revised CloudantOutNode message output option simplifying to just yes/no, to return the msg, with errors returned via node.error(). updated README.md and 77-cloudant-cf.html doco to reflect changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on the really useful change to support output messages from CloudantOutNode, these mods (hopefully) simplify and standardize error handling.
Ensuring that the msg is returned on errors, allow flows to be built that can recover from race conditions / update contention issues.
Key changes:
Revised error handling to ensure all errors are raised via node.error(err, msg)
Revised message handling to ensure the original message is returned un-changed on errors.
Revised CloudantOutNode message output option simplifying to just yes/no, to return the msg, with errors returned via node.error().
updated README.md and 77-cloudant-cf.html doco to reflect changes.