meta: specify rust-version and add cargo-msrv to CI#100
Merged
KillingSpark merged 3 commits intoKillingSpark:masterfrom Feb 27, 2026
Merged
meta: specify rust-version and add cargo-msrv to CI#100KillingSpark merged 3 commits intoKillingSpark:masterfrom
KillingSpark merged 3 commits intoKillingSpark:masterfrom
Conversation
* style(sequence decoder): migrate .is_some() -> .unwrap to if let to make clippy happy * feat(cli): replace unix specific code with os generic variant
Owner
|
Thanks! That kinda went missing on my todo list, sorry about that. I'll have a closer look tomorrow and merge this if nothing comes up |
Owner
|
This looks good, I am just a bit confused why you didn't base this on the latest commit? This includes some duplicated changes to fix clippy lints. Is there any reason this isn't based on a39b341 ? It doesn't really matter, the outcome will be the same it just makes the PR a bit messier than it needs to be. |
Contributor
Author
|
I forgot to merge changes from your fork into my branch until after the fact😅 |
Owner
|
Ah right that makes sense :) Anyways, lgtm thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #96
I asked for your approval then promptly realized that it's easy enough that I can just do it and you can decide whether or not to merge it.
This adds a check to CI that validates that the
rust-versionspecified under each crate'sCargo.tomlis actually able to compile the project.A semantic version bump was included, and the changelog updated.