-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Revert PR #3533 and fix SQLite bundling #3557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
markijbema
wants to merge
8
commits into
main
Choose a base branch
from
mark/sqlite
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
44f3df8
Revert PR #3533 and fix SQLite bundling
markijbema db8025b
also add bindings
markijbema f17bf9a
fix
markijbema e5d2b68
add debug
markijbema 41287f9
simplify
markijbema ffa350c
update debug
markijbema 341ba99
begone
markijbema 7ea1405
update debug
markijbema File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -29,6 +29,9 @@ async function main() { | |
| format: "cjs", | ||
| sourcesContent: false, | ||
| platform: "node", | ||
| loader: { | ||
| ".node": "file", | ||
| }, | ||
| } | ||
|
|
||
| const srcDir = __dirname | ||
|
|
@@ -67,6 +70,59 @@ async function main() { | |
| // Copy tree-sitter files to dist directory | ||
| copyPaths([["services/continuedev/tree-sitter", "tree-sitter"]], srcDir, distDir) | ||
|
|
||
| // Helper function to find and copy a package | ||
| // This dynamically resolves package locations to avoid hardcoded version numbers | ||
| const copyPackage = (packageName) => { | ||
| let packageSource = null | ||
| try { | ||
| const require = createRequire(import.meta.url) | ||
| const packagePath = require.resolve(`${packageName}/package.json`) | ||
| packageSource = path.dirname(packagePath) | ||
| } catch (err) { | ||
| // Fallback: try to find it in pnpm structure | ||
| const pnpmDir = path.join(srcDir, "../node_modules/.pnpm") | ||
| if (fs.existsSync(pnpmDir)) { | ||
| const entries = fs.readdirSync(pnpmDir) | ||
| for (const entry of entries) { | ||
| if (entry.startsWith(`${packageName}@`)) { | ||
| const packagePath = path.join(pnpmDir, entry, "node_modules", packageName) | ||
| if (fs.existsSync(packagePath)) { | ||
| packageSource = packagePath | ||
| break | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| if (packageSource && fs.existsSync(packageSource)) { | ||
| const packageDest = path.join(distDir, "node_modules", packageName) | ||
| try { | ||
| fs.cpSync(packageSource, packageDest, { recursive: true }) | ||
| console.log(`[${name}] Copied ${packageName} package to dist/node_modules/${packageName}`) | ||
| return true | ||
| } catch (err) { | ||
| console.error(`[${name}] Failed to copy ${packageName} package:`, err) | ||
| return false | ||
| } | ||
| } else { | ||
| console.warn(`[${name}] ${packageName} source not found`) | ||
| return false | ||
| } | ||
| } | ||
|
|
||
| // Copy sqlite3 and sqlite native bindings to dist directory | ||
| // This is necessary because they are marked as external in esbuild | ||
| // and contain platform-specific .node binaries that must be included | ||
| copyPackage("sqlite3") | ||
| copyPackage("sqlite") | ||
|
Comment on lines
+117
to
+118
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. do we need both? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yes, though I'm not sure why |
||
|
|
||
| // Copy bindings package (required by sqlite3) | ||
| copyPackage("bindings") | ||
|
|
||
| // Copy file-uri-to-path (required by bindings) | ||
| copyPackage("file-uri-to-path") | ||
|
|
||
| // Copy JSDOM xhr-sync-worker.js to fix runtime resolution | ||
| const jsdomWorkerDest = path.join(distDir, "xhr-sync-worker.js") | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we care about this fallback or should we just fail?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3/4 packages use the fallback