Skip to content

Conversation

@jrf0110
Copy link
Contributor

@jrf0110 jrf0110 commented Nov 6, 2025

Context

On initial load, an autocomplete model/provider would not get loaded until an auto-complete setting changed.

Implementation

Removes the initial default value of ghostServiceSettings and lets GhostServiceManager handle its own defaults

Screenshots

before after
image image

How to Test

  • Reset settings in extension
  • Re-login
  • Navigate to autocomplete settings
  • Observe that a default model is selected

@changeset-bot
Copy link

changeset-bot bot commented Nov 6, 2025

⚠️ No Changeset found

Latest commit: 0d5b36a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Collaborator

@beatlevic beatlevic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants