Delphi Make Dictionary Static and Dont initialize Array.#1
Open
glenkleidon wants to merge 4 commits intoKimMadsen:patch-1from
Open
Delphi Make Dictionary Static and Dont initialize Array.#1glenkleidon wants to merge 4 commits intoKimMadsen:patch-1from
glenkleidon wants to merge 4 commits intoKimMadsen:patch-1from
Conversation
Converted the dictionary to a static object.
6 tasks
Removed Initializer by reversing logic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changed the Dictionary to a static object.
As pointed out by Dave Plummer in the most recent (Delphi Vs Ada)[https://www.youtube.com/watch?v=tQtFdsEcK_s&t=31s] video, this original implementation creates the History Dictionary dynamically each time when it should be static. This means it does not need to create or destroy the history as a private member.
I also eliminated the need to re-initialize the FBitarray with TRUE which was a significant bottleneck.
Contributing requirements
drag-raceas the target branch.