fixes and enhancements around logfile usage #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closing the report file (done under options lock) triggers memory operation, and a deadlock in multithreaded programs, because callstack was also accessing the options variable using locking. This patch removes locks around callstack option access, like the existing showInternalFrames parameter. It can lead to a (harmless) data race, but no longer to a deadlock
Since dumping memory can be slow, this patch allows read access from other programs during write (e.g. notepad)
vld report writer maintans a private copy of output FILE pointer. After closing it, we need to notify the report writer.
chris1248
reviewed
Oct 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch series adds: