Skip to content

Replace mock-fs with memfs#129

Open
ookkoouu wants to merge 1 commit intoKira-NT:devfrom
ookkoouu:use-memfs
Open

Replace mock-fs with memfs#129
ookkoouu wants to merge 1 commit intoKira-NT:devfrom
ookkoouu:use-memfs

Conversation

@ookkoouu
Copy link

@ookkoouu ookkoouu commented Oct 8, 2024

Description

mock-fs doesn't work on NodeJS 20, use memfs instead.
https://github.com/streamich/memfs

All tests passed in NodeJS 22.9.0.

Implementation Notes

  • mock fs fs/promises in all tests
  • removed yazl, use adm-zip
    • yazl was used to create a dummy zip file, but the tests timed out, so it was replaced with adm-zip, which has a synchronous method available.

Checklist

  • Added unit tests for every exported function/class.
  • Added JSDoc to every public function/class/class member.
  • Added relevant information to the README.

@Kira-NT
Copy link
Owner

Kira-NT commented Oct 11, 2024

Thanks for being an absolute MVP! :D
I haven't started working on the tests yet, so I really appreciate you making this part easier for me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants