Conversation
Fixes "Risugami's Modloader"
|
Hey! Thanks so much for your endeavors - I really appreciate it! As for the PR itself: unfortunately, I can't merge it at this point in time. TL;DR - this tree is basically dead, as I'm in the process of rewriting the entire thing: the GitHub Actions-centric nature of this project proved to cause nothing but problems (it's hard to debug, difficult to test, and GitHub doesn't even provide LTS versions of Node for developers to target, and prefers to just constantly scream at you and your users about STS runtimes being deprecated). So, I'm rebuilding mc-publish as a regular cli utility, which can then be packaged in a Docker container for GitHub Actions to consume, or integrated with a Gradle plugin, or just used on its own. That said, I'd be happy to credit you as a co-author on a similar commit in the new tree, since without your input I wouldn't have even realized that there are issues with older Minecraft versions that I need to fix :) (Note, though, that the new version is written in C#, as I've grown pretty tired of JS) |
|
You're more than welcome! :) I have noticed that debugging is rather hard - I always relied on adding random You don't need to credit me as a co-author - this was only a very, very basic change :) I will just leave this PR open - feel free to merge it, ignore it, close it - whatever you want! |
Description
Fix targeting/tagging beta versions as well as Risugami's Modloader on CurseForge
Current Behavior
No version is tagged at all (it tries to tag 1.0-SNAPSHOT as far as I can tell, but this is not shown in the new interface)
Updated Behavior
Now, beta versions are properly tagged. This behaviour is also now tested in the unit tests.
Implementation Notes
Should be rather obvious - the version is extracted out of the version ID.
Checklist
Breaking Changes
Could be considered a breaking change... But I don't really think so.
Fixed Issues
Fixes #156