Skip to content

Fix beta versions on CurseForge#157

Open
ThexXTURBOXx wants to merge 2 commits intoKira-NT:devfrom
ThexXTURBOXx:dev
Open

Fix beta versions on CurseForge#157
ThexXTURBOXx wants to merge 2 commits intoKira-NT:devfrom
ThexXTURBOXx:dev

Conversation

@ThexXTURBOXx
Copy link

@ThexXTURBOXx ThexXTURBOXx commented Jun 3, 2025

Description

Fix targeting/tagging beta versions as well as Risugami's Modloader on CurseForge

Current Behavior

No version is tagged at all (it tries to tag 1.0-SNAPSHOT as far as I can tell, but this is not shown in the new interface)

Updated Behavior

Now, beta versions are properly tagged. This behaviour is also now tested in the unit tests.

Implementation Notes

Should be rather obvious - the version is extracted out of the version ID.

Checklist

  • Added unit tests for every exported function/class.
  • Added JSDoc to every public function/class/class member.
  • Added relevant information to the README.

Breaking Changes

Could be considered a breaking change... But I don't really think so.

Fixed Issues

Fixes #156

@Kira-NT
Copy link
Owner

Kira-NT commented Jun 7, 2025

Hey! Thanks so much for your endeavors - I really appreciate it!
I never actually tested how this action plays along with older betas and alphas of Minecraft, because, to be quite frankly honest with you, I didn't think anyone was still developing for those :) I'll definitely make sure to show those versions a bit more love in this project going forward!

As for the PR itself: unfortunately, I can't merge it at this point in time. TL;DR - this tree is basically dead, as I'm in the process of rewriting the entire thing: the GitHub Actions-centric nature of this project proved to cause nothing but problems (it's hard to debug, difficult to test, and GitHub doesn't even provide LTS versions of Node for developers to target, and prefers to just constantly scream at you and your users about STS runtimes being deprecated). So, I'm rebuilding mc-publish as a regular cli utility, which can then be packaged in a Docker container for GitHub Actions to consume, or integrated with a Gradle plugin, or just used on its own.

That said, I'd be happy to credit you as a co-author on a similar commit in the new tree, since without your input I wouldn't have even realized that there are issues with older Minecraft versions that I need to fix :) (Note, though, that the new version is written in C#, as I've grown pretty tired of JS)

@ThexXTURBOXx
Copy link
Author

You're more than welcome! :)
And yes, there is actually a (let's call it "considerably large") community for b1.7.3 modding.

I have noticed that debugging is rather hard - I always relied on adding random console.log calls everywhere, pushing it to GitHub and then using https://github.com/nektos/act to run the action on my machine.
A few years ago, I also made a very basic CLI utility for the same reasons in order to publish my mod "Block Helper" - but it only worked for what I wanted to do with it, so it's not really extensible.

You don't need to credit me as a co-author - this was only a very, very basic change :)
But thank you for the offer anyway! (and yes, I am also rather tired of JS and TS, so I completely understand your standpoint)

I will just leave this PR open - feel free to merge it, ignore it, close it - whatever you want!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants