Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
sponge_plugins.jsonfor Sponge (#23). Note this is included in the/META-INF/directory in plugin jarfile and, in most cases, generated by the sponge gradle plugin or annotations. This file has been tested and passes with Sponge API v8.1.0. v7 and lower accept a different format entirely (mcmod.toml iirc)Sponge is quite strict with parsing these files, so it's not possible to add custom mc-publish metadata fields. Even if it was, it wouldn't really be helpful due to the way these files are generated for the vast majority of sponge users.
spongeis accepted as the supported loader.globalfield apply to each plugin in thepluginsfield and plugins can provide their own overriding parameters. Theid,name,descriptionandentrypointparameters cannot be set in theglobalfield and must be set for each plugin inplugins. At least one plugin is required in thepluginsfield for it to be valid. Thus, you can grab the name and ID from the first plugin in thepluginsarray.(this PR supercedes #34)