[WIP] Add generic derivation to org.bson.BsonValue#19
Open
ronanM wants to merge 28 commits intoKirill5k:masterfrom
Open
[WIP] Add generic derivation to org.bson.BsonValue#19ronanM wants to merge 28 commits intoKirill5k:masterfrom
ronanM wants to merge 28 commits intoKirill5k:masterfrom
Conversation
Owner
|
Wow, this is beyond my understanding of Scala 😅 Sorry, I've just pushed some changes which might interfere with your PR |
Contributor
Author
|
What I want is to use I have added a small PoC: https://github.com/Kirill5k/mongo4cats/blob/7a4890d82a2291d9e8da243fdd0d2ae6d4ed2bb4/bson-derivation/src/test/scala-2/mongo4cats/MongoBsonCollectionSpec.scala |
Contributor
Author
|
I've had added some benches. Read: Write: |
Contributor
Contributor
Author
|
From my part, I have no more time to work on this. This PoC is highly unsafe/low-level (reduce the allocations as much as possible) in comparison to the safety of Circe. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Magnolia generic derivation to
org.bson.BsonValuefor Scala2.12,2.13and3(with minimalist test).The aim of this work is to encode/decode like
mongo4cats-circebut directly from ADT toorg.bson.BsonValue.Tests using:
$ sbt "~+mongo4cats-bson-derivation/testQuick"