Merged
Conversation
adamchalmers
force-pushed
the
achalmers/kcl-85
branch
from
14bbe29 to
29b5693
Compare
adamchalmers
force-pushed
the
achalmers/kcl-85
branch
from
3858e9f to
7ab4594
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1295 +/- ##
==========================================
- Coverage 74.82% 74.80% -0.02%
==========================================
Files 37 37
Lines 5629 5629
==========================================
- Hits 4212 4211 -1
- Misses 1417 1418 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jtran
approved these changes
Jul 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump KCL from 80 to 85. This included a bugfix for units of measurement in KCL 81, which was causing the old tests to report different physical properties (e.g. mass, volume). So I changed the gear.kcl sample file to match the latest sample from the website, and changed the expected measurements.