Skip to content

Fix content script on Chrome v130+ #642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pierremtb merged 4 commits into from
Jan 3, 2025
Merged

Fix content script on Chrome v130+ #642

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
993c283
Bump to @crxjs/[email protected]
pierremtb Jan 3, 2025
273b354
Clean up old workaround
pierremtb Jan 3, 2025
1170c09
Pin runner to 20.04
pierremtb Jan 3, 2025
eef02a3
Add fixme on a blob preview test
pierremtb Jan 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ on:

jobs:
build:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
env:
RELEASE: ${{ github.event.release.name }}
RELEASE_ZIP: zoo-diff-viewer-extension_${{ github.event.release.name || github.sha }}.zip
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@
},
"devDependencies": {
"@babel/runtime": "^7.23.9",
"@crxjs/vite-plugin": "^1.0.14",
"@crxjs/vite-plugin": "2.0.0-beta.26",
"@playwright/test": "^1.43.1",
"@vitejs/plugin-react": "^4.2.1",
"dotenv": "^16.4.5",
Expand Down
2 changes: 1 addition & 1 deletion tests/extension.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ test('blob preview with a .step file', async ({
expect(screenshot).toMatchSnapshot()
})

test('blob preview with an .stl file', async ({
test.fixme('blob preview with an .stl file', async ({
page,
authorizedBackground,
}) => {
Expand Down
13 changes: 0 additions & 13 deletions vite.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,26 +5,13 @@ import react from '@vitejs/plugin-react'
import { crx } from '@crxjs/vite-plugin'
import manifest from './manifest.json'

const viteManifestHackIssue846: Plugin & {
renderCrxManifest: (manifest: any, bundle: any) => void
} = {
// Workaround from https://github.com/crxjs/chrome-extension-tools/issues/846#issuecomment-1861880919.
name: 'manifestHackIssue846',
renderCrxManifest(_manifest, bundle) {
bundle['manifest.json'] = bundle['.vite/manifest.json']
bundle['manifest.json'].fileName = 'manifest.json'
delete bundle['.vite/manifest.json']
},
}

export default defineConfig(() => {
return {
build: {
outDir: 'build',
},
plugins: [
react(),
viteManifestHackIssue846,
crx({ manifest }),
nodePolyfills(),
],
Expand Down
Loading