Skip to content

Conversation

@adamchalmers
Copy link
Collaborator

@adamchalmers adamchalmers commented Jan 5, 2026

I think this file was accidentally added in #978 because I changed the expectorate path halfway through development.

You can see that I clearly added two copies of api.json in the original PR:
Screenshot 2026-01-05 at 11 53 03 AM

but only one of them is used in the actual test I added there.

I think this file was accidentally added in #978
because I changed the expectorate path halfway through development.
@codecov
Copy link

codecov bot commented Jan 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@c414853). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1029   +/-   ##
=======================================
  Coverage        ?   29.29%           
=======================================
  Files           ?       35           
  Lines           ?     1724           
  Branches        ?        0           
=======================================
  Hits            ?      505           
  Misses          ?     1219           
  Partials        ?        0           
Flag Coverage Δ
unittests 29.29% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@adamchalmers adamchalmers merged commit 41a2a9a into main Jan 5, 2026
5 checks passed
@adamchalmers adamchalmers deleted the achalmers/remove-old-file branch January 5, 2026 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants