Skip to content

Conversation

@gserena01
Copy link
Contributor

@codecov
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@95eafdb). Learn more about missing BASE report.

Files with missing lines Patch % Lines
modeling-cmds/src/shared.rs 0.00% 3 Missing ⚠️
modeling-cmds/src/def_enum.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #612   +/-   ##
=======================================
  Coverage        ?   25.13%           
=======================================
  Files           ?       35           
  Lines           ?     2113           
  Branches        ?        0           
=======================================
  Hits            ?      531           
  Misses          ?     1582           
  Partials        ?        0           
Flag Coverage Δ
unittests 25.13% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lf94
Copy link
Contributor

lf94 commented Jan 27, 2025

Good or bad to merge ?

@gserena01
Copy link
Contributor Author

@lf94 the engine companion pr isn't ready yet...I may convert to a draft in the meantime

@gserena01 gserena01 marked this pull request as draft January 27, 2025 15:16
@gserena01 gserena01 marked this pull request as ready for review February 11, 2025 21:07
@gserena01 gserena01 merged commit 61c2d3b into main Feb 11, 2025
9 checks passed
@gserena01 gserena01 deleted the serena/orient-to-face branch February 11, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants