Skip to content

ExtrusionFaceInfo::list_faces should be a method #683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamchalmers merged 1 commit into from
Dec 13, 2024
Merged

ExtrusionFaceInfo::list_faces should be a method #683

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions modeling-cmds/src/shared.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -842,8 +842,8 @@ fn z_axis() -> Point3d<f64> {
impl ExtrudedFaceInfo {
/// Converts from the representation used in the Extrude modeling command,
/// to a flat representation.
pub fn list_faces(faces: ExtrudedFaceInfo) -> Vec<ExtrusionFaceInfo> {
let mut face_infos: Vec<_> = faces
pub fn list_faces(self) -> Vec<ExtrusionFaceInfo> {
let mut face_infos: Vec<_> = self
.sides
.into_iter()
.map(|side| ExtrusionFaceInfo {
Expand All @@ -854,10 +854,10 @@ impl ExtrudedFaceInfo {
.collect();
face_infos.push(ExtrusionFaceInfo {
curve_id: None,
face_id: Some(faces.top),
face_id: Some(self.top),
cap: ExtrusionFaceCapType::Top,
});
if let Some(bottom) = faces.bottom {
if let Some(bottom) = self.bottom {
face_infos.push(ExtrusionFaceInfo {
curve_id: None,
face_id: Some(bottom),
Expand Down
Loading