Skip to content

ensure we dont serialize if none#744

Merged
jessfraz merged 1 commit intomainfrom
ensure-we-dont-serialize-if-none
Jan 27, 2025
Merged

ensure we dont serialize if none#744
jessfraz merged 1 commit intomainfrom
ensure-we-dont-serialize-if-none

Conversation

@jessfraz
Copy link
Contributor

part of #566

Signed-off-by: Jess Frazelle <github@jessfraz.com>
@jessfraz jessfraz requested a review from adamchalmers January 27, 2025 19:10
@codecov
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@0ac5c37). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #744   +/-   ##
=======================================
  Coverage        ?   25.23%           
=======================================
  Files           ?       35           
  Lines           ?     2104           
  Branches        ?        0           
=======================================
  Hits            ?      531           
  Misses          ?     1573           
  Partials        ?        0           
Flag Coverage Δ
unittests 25.23% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jessfraz jessfraz merged commit a18cb7f into main Jan 27, 2025
9 checks passed
@jessfraz jessfraz deleted the ensure-we-dont-serialize-if-none branch January 27, 2025 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant