Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #782 +/- ##
=======================================
Coverage ? 24.64%
=======================================
Files ? 36
Lines ? 2155
Branches ? 0
=======================================
Hits ? 531
Misses ? 1624
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| #[cfg_attr(feature = "ts-rs", ts(export_to = "ModelingCmd.ts"))] | ||
| pub struct CameraViewState { | ||
| pub pivot_rotation: [f32; 4], | ||
| pub pivot_position: [f32; 3], |
There was a problem hiding this comment.
I think this should use our dedicated Point type, because it's not just 3 arbitrary number, it represents a specific point in space, right?
| pub pivot_position: [f32; 3], | |
| pub pivot_position: Point3d<f32>, |
There was a problem hiding this comment.
I was avoiding it here since this type passes through an FFI boundary and Point3d isn't repr(C).
I might be erring on the side of caution unnecessarily though - is it ok to have non repr(C) fields in a repr(C) struct? Will follow up with another PR if so.
Co-authored-by: Adam Chalmers <adam.chalmers@zoo.dev>
Adds commands for getting/setting the default camera view. Required by engine PR 3121.