KCL: More flexible vector::cross #7837
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jtran
previously approved these changes
Jul 18, 2025
CodSpeed Instrumentation Performance ReportMerging #7837 will not alter performanceComparing Summary
|
|
From Slack, I think the easiest thing here is to emulate a generic by implementing in Rust. The better but harder solution is to make |
jtran
dismissed
their stale review
This is no longer needed for hole support. Maybe we should implement this in Rust.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the example KCL test would not run, it would fail at runtime with an error that you can't convert [number(unknown); 3] to point3d.