KCL: Preallocate space for all the paths #7843
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you sketch a 100-sided shape, Rust will append 100 path segments to the underlying sketch. Unfortunately because the vector which stores the paths starts at capacity 0, this could cause quite a lot of allocations. As an optimization, we will instead preallocate space for N paths, where N is the number of steps in the |> pipeline. This will hopefully reduce allocations.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
CodSpeed Instrumentation Performance ReportMerging #7843 will degrade performances by 13.53%Comparing Summary
Benchmarks breakdown
Footnotes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you sketch a 100-sided shape, Rust will append 100 path segments to the underlying sketch. Unfortunately because the vector which stores the paths starts at capacity 0, this could cause quite a lot of allocations.
As an optimization, we will instead preallocate space for N paths, where N is the number of steps in the |> pipeline. This will hopefully reduce allocations.
This improves performance on
mock_execute_mike_stress_test5% on my Macbook (M2 Pro) but regresses it 14% on Codspeed. I don't know why there's such a big difference.