KCL: Try parsing [1, 2, 3] before [1..3] #7859
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arrays can be either element-by-element or a range. KCL programs use element-by-element more, because that's how points and axes are represented. We should parse the more common case (elemnt-by-element) before trying the less common case (ranges). This change improves parse speed by ~20-30% on my macbook.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Confused why this made a bunch of tests fail, I guess because in the case of errors we do ErrMode::Cut instead of ErrMode::Backtrack. But we need to do Cut to prevent the compiler error from being swallowed. Hmm. |
|
In |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arrays can be either element-by-element or a range. KCL programs use element-by-element more, because that's how points and axes are represented.
We should parse the more common case (elemnt-by-element) before trying the less common case (ranges). This change improves parse speed significantly on my macbook (15-45%):