Skip to content

Fix sweep() tagEnd #7870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Fix sweep() tagEnd #7870

wants to merge 5 commits into from

Conversation

jtran
Copy link
Contributor

@jtran jtran commented Jul 21, 2025

#7695

Not ready yet. Engine error.

Screenshot 2025-07-21 at 2 12 20 PM

This PR tries to use the ID of the sketch on the face, rather than the original solid's sketch ID. As you can see from the screenshot, this almost works. The upperSection starts from the plane of the bent section, which is what we want. But there's some kind of internal engine error when getting the Solid3dGetAdjacencyInfo of the sketch ID. Moving the rectangle center doesn't fix it.

Copy link

vercel bot commented Jul 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 21, 2025 6:56pm

Copy link

codspeed-hq bot commented Jul 21, 2025

CodSpeed Instrumentation Performance Report

Merging #7870 will not alter performance

Comparing jtran/sweep-tag-end (532795d) with main (88fad30)1

Summary

✅ 89 untouched benchmarks

Footnotes

  1. No successful run was found on main (da1d933) during the generation of this report, so 88fad30 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant