Skip to content

Allow Create parameter to work in Sketch mode #7871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Allow Create parameter to work in Sketch mode #7871

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
314b1e3
Allow Create parameter to work in Sketch mode
pierremtb Jul 21, 2025
9332f4b
Update snapshots
github-actions[bot] Jul 21, 2025
d7b32ae
Update snapshots
github-actions[bot] Jul 21, 2025
fc50c56
Merge branch 'main' into pierremtb/issue7670-Allow-Create-parameter-t…
pierremtb Jul 23, 2025
4c08fe8
Update snapshots
github-actions[bot] Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified ...ts.spec.ts-snapshots/Draft-segments-should-look-right-3-Google-Chrome-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
5 changes: 5 additions & 0 deletions src/machines/modelingMachine.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3630,6 +3630,11 @@ export const modelingMachine = setup({
target: 'Change Tool',
reenter: true,
},

'event.parameter.create': {
target: '#Modeling.state:parameter:creating',
guard: 'no kcl errors',
},
},

states: {
Expand Down
Loading