docs: Change KCL docs examples to use startProfile() with explicit argument #7885
+368
−389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jtran
force-pushed
the
jtran/docs-start-profile-no-pipe
branch
from
504c1db to
b0cb94d
Compare
jacebrowning
approved these changes
Jul 23, 2025
|
Output images changed because the lines that extruded were commented with regular comments |
ksbharaj
approved these changes
Jul 23, 2025
adamchalmers
approved these changes
Jul 23, 2025
There was a problem hiding this comment.
Do you know why these changed? I thought the rectangles were already extruded on main.
There was a problem hiding this comment.
Yes, I already commented on this. #7885 (comment)
jtran
commented
Jul 23, 2025
| /// |> rectangle(center = [0, 0], width = 10, height = 5) | ||
| // |> extrude(length = 2) | ||
| /// rectSolid = rectangle(exampleSketch, center = [0, 0], width = 10, height = 5) | ||
| /// |> extrude(length = 2) |
There was a problem hiding this comment.
@adamchalmers, see the missing slash that I fixed here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of:
change to:
This is more like how the app generates code, and it will hopefully give more examples to Text-to-CAD that the first parameter is required. Text-to-CAD seems to get this wrong a lot.
This doesn't update everything. We can follow-up with more if needed.