Right click a feature on the model to center the code pane on it #7890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: we really cannot do this * fix: limiting footprint
…e' mode * add ability to select deoffset plane where starting a new sketch * use selectDefaultSketchPlane * refactor: remove some duplication * warning cleanups * feature tree items selectable depedngin on no face sketch mode * lint * fix small jump because of border:none when going into and back from 'No face sketch' mode * grey out items other than offset planes in 'No face sketch' mode * start sketching on plane in context menu * sketch on offset plane with context menu * add ability to right click on default plane and start sketch on it * default planes in feature tree should be selectable because of right click context menu * add right click Start sketch option for selected plane on the canvas * selectDefaultSketchPlane returns error now * circular deps * move select functions to lib/selections.ts to avoid circular deps * add test for clicking on feature tree after starting a new sketch * graphite suggestion * fix bug of not being able to create offset plane using another offset plane with command bar * add ability to select default plane on feature when going through the Offset plane command bar flow
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
andrewvarga
reviewed
Aug 25, 2025
| @@ -94,7 +144,13 @@ export function useViewControlMenuItems() { | |||
| <ContextMenuItemRefresh />, | |||
| ], | |||
| // eslint-disable-next-line react-hooks/exhaustive-deps -- TODO: blanket-ignored fix me! | |||
| [VIEW_NAMES_SEMANTIC, shouldLockView, selectedPlaneId] | |||
| [ | |||
There was a problem hiding this comment.
Maybe this depdendency list could be fixed, while we're here, looks easy to remove VIEW_NAMES_SEMANTIC and add modelingSend.
But no need to block this PR for that.
There was a problem hiding this comment.
Nice thanks for noticing this! Fixed at b79bcf9
andrewvarga
approved these changes
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rajgandhi1's PR at #7664, recreated as a local branch so we can get CI to pass.
We should still address #7664 (comment) (done!)