-
Notifications
You must be signed in to change notification settings - Fork 87
Right click a feature on the model to center the code pane on it #7890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+127
−8
Merged
Changes from 25 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
347e635
Right click a feature on the model to center the code pane on it #7447
rajgandhi1 4aa6aa6
bug fixes
rajgandhi1 4915eb7
Merge branch 'KittyCAD:main' into view_kcl_code
rajgandhi1 bb6c9f7
Merge branch 'KittyCAD:main' into view_kcl_code
rajgandhi1 2279aa2
[Bug fix]: Do not store token in window! (#7671)
nadr0 5e5d421
* Add ability to pick default plane in feature tree in 'Sketch no fac…
andrewvarga a4c1258
Right click a feature on the model to center the code pane on it #7447
rajgandhi1 c1c4684
bug fixes
rajgandhi1 a0b9880
Merge branch 'main' into view_kcl_code
rajgandhi1 4a11eb2
Merge branch 'KittyCAD:main' into view_kcl_code
rajgandhi1 cba6ab9
Merge branch 'KittyCAD:main' into view_kcl_code
rajgandhi1 ee2e394
Merge branch 'KittyCAD:main' into view_kcl_code
rajgandhi1 039d7b3
removed duplicate code.
rajgandhi1 4549789
added basic playwright test
rajgandhi1 037cf6d
Merge branch 'main' into view_kcl_code
rajgandhi1 7746ff3
Merge branch 'main' into rajgandhi1/view_kcl_code
pierremtb 68a2155
Merge branch 'main' into rajgandhi1/view_kcl_code
pierremtb a1cf11c
Merge branch 'main' into rajgandhi1/view_kcl_code
pierremtb e847fce
Merge branch 'main' into rajgandhi1/view_kcl_code
pierremtb 680dbab
Unify repeated logic and move test to testing-selections spec file
pierremtb 833b922
Merge branch 'main' into rajgandhi1/view_kcl_code
pierremtb 8159f75
Merge branch 'main' into rajgandhi1/view_kcl_code
pierremtb d233e48
Merge branch 'main' into rajgandhi1/view_kcl_code
pierremtb 2457714
Merge branch 'main' into rajgandhi1/view_kcl_code
pierremtb 08b404f
Add test case for succesful right click to code
pierremtb b79bcf9
Remove TODO and clean up useMemo deps
pierremtb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this depdendency list could be fixed, while we're here, looks easy to remove
VIEW_NAMES_SEMANTIC
and addmodelingSend
.But no need to block this PR for that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice thanks for noticing this! Fixed at b79bcf9