Skip to content

#1502 Add snap to grid to sketch mode #7893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 51 commits into
base: main
Choose a base branch
from

Conversation

andrewvarga
Copy link
Contributor

@andrewvarga andrewvarga commented Jul 24, 2025

I'm thinking we could have a dropdown of 3 options for snapping, instead of just an on/off boolean:

  • snapping off
  • snap to default units
  • snap to grid

That said, I have trouble imagining "snap to grid" being very useful with the current grid. On my screen these are the 2 extremes I have for the grid size:

  • Largest: only a few grids fit on the screen, snapping to the grid intersections would be pretty large jumps, doesn't feel like it would be useful. It's a similar to using default units and zooming in too much as you mentioned.
Image
  • Smallest possible grids: still only 10 grids fit my screen per row, so still a bit too big jumps. This could be improved by:
    • Changing the grid zoom steps to allow grids to be smaller
    • Make the grid infinite to cover the screen, then 2x more grids would be visible per row
Image

With those changes it could be useful to have the "snap to grid" option too, but I should change those things first then (?).

Related: am I correct that the "Fixed Size Grid" setting only applies to outside of sketch mode, not within sketch mode where it seems to have no effect? I wonder if that is on purpose or it should be fixed first too.

@andrewvarga andrewvarga requested review from a team as code owners July 24, 2025 17:30
Copy link

vercel bot commented Jul 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2025 4:44pm

@andrewvarga andrewvarga marked this pull request as draft July 24, 2025 17:30
Copy link

codspeed-hq bot commented Jul 24, 2025

CodSpeed Instrumentation Performance Report

Merging #7893 will not alter performance

Comparing andrewvarga/1502/add-snap-to-grid-to-sketch-mode (a39bad1) with main (7235ab4)

Summary

✅ 89 untouched benchmarks

@pierremtb pierremtb linked an issue Jul 24, 2025 that may be closed by this pull request
2 tasks
@andrewvarga
Copy link
Contributor Author

Update from sync today:

  • Let the user set the grid size explicitly (eg. feet, 5 inches, 10mm), the grid being an infinite grid (current grid leaves empty space on the edge of the screen). The grid size is not dependant on current zoom level in the first pass of the implementation.
  • The user can snap to the grid, this grid snapping is lower priority than other snappings: tangent to line, tangent to start profile, main axes.
  • We can have a second, grayed out lower level grid which is dependend on the zoom level.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add snap-to-unit-grid to sketch mode
1 participant