-
Notifications
You must be signed in to change notification settings - Fork 85
#1502 Add snap to grid to sketch mode #7893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
andrewvarga
wants to merge
51
commits into
main
Choose a base branch
from
andrewvarga/1502/add-snap-to-grid-to-sketch-mode
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
#1502 Add snap to grid to sketch mode #7893
andrewvarga
wants to merge
51
commits into
main
from
andrewvarga/1502/add-snap-to-grid-to-sketch-mode
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
CodSpeed Instrumentation Performance ReportMerging #7893 will not alter performanceComparing Summary
|
2 tasks
Update from sync today:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm thinking we could have a dropdown of 3 options for snapping, instead of just an on/off boolean:
That said, I have trouble imagining "snap to grid" being very useful with the current grid. On my screen these are the 2 extremes I have for the grid size:
With those changes it could be useful to have the "snap to grid" option too, but I should change those things first then (?).
Related: am I correct that the "Fixed Size Grid" setting only applies to outside of sketch mode, not within sketch mode where it seems to have no effect? I wonder if that is on purpose or it should be fixed first too.