Skip to content

Bump the patch group across 1 directory with 3 updates #7915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −9
Open

Bump the patch group across 1 directory with 3 updates #7915

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/build-apps.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,19 +362,19 @@ jobs:

- name: Authenticate to Google Cloud
if: ${{ env.IS_STAGING == 'true' }}
uses: 'google-github-actions/[email protected].10'
uses: 'google-github-actions/[email protected].12'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a version discrepancy in this PR. The description indicates updating google-github-actions/auth from v2.1.10 to v2.1.11, but the actual code changes show an update to v2.1.12.

Please either:

  1. Update the PR description to reflect the v2.1.12 target version, or
  2. Modify the code to use v2.1.11 as described in the PR

This ensures consistency between the description and implementation, which helps with future auditing and change tracking.

Suggested change
uses: 'google-github-actions/[email protected].12'
uses: 'google-github-actions/[email protected].11'

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

with:
credentials_json: '${{ secrets.GOOGLE_CLOUD_DL_SA }}'

- name: Set up Google Cloud SDK
if: ${{ env.IS_STAGING == 'true' }}
uses: google-github-actions/[email protected].4
uses: google-github-actions/[email protected].5
with:
project_id: ${{ env.GOOGLE_CLOUD_PROJECT_ID }}

- name: Upload staging files to public bucket
if: ${{ env.IS_STAGING == 'true' }}
uses: google-github-actions/[email protected].2
uses: google-github-actions/[email protected].3
with:
path: out
glob: '*'
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/kcl-language-server.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,16 +329,16 @@ jobs:
mkdir -p releases/language-server/${{ env.TAG }}
cp -r build/* releases/language-server/${{ env.TAG }}
- name: "Authenticate to Google Cloud"
uses: "google-github-actions/[email protected].10"
uses: "google-github-actions/[email protected].12"
with:
credentials_json: "${{ secrets.GOOGLE_CLOUD_DL_SA }}"
- name: Set up Cloud SDK
uses: google-github-actions/[email protected].4
uses: google-github-actions/[email protected].5
with:
project_id: kittycadapi
- name: "upload files to gcp"
id: upload-files
uses: google-github-actions/[email protected].2
uses: google-github-actions/[email protected].3
with:
path: rust/releases
destination: dl.kittycad.io
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/publish-apps-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,17 +108,17 @@ jobs:
run: npm run files:set-notes

- name: Authenticate to Google Cloud
uses: 'google-github-actions/[email protected].10'
uses: 'google-github-actions/[email protected].12'
with:
credentials_json: '${{ secrets.GOOGLE_CLOUD_DL_SA }}'

- name: Set up Google Cloud SDK
uses: google-github-actions/[email protected].4
uses: google-github-actions/[email protected].5
with:
project_id: ${{ env.GOOGLE_CLOUD_PROJECT_ID }}

- name: Upload release files to public bucket
uses: google-github-actions/[email protected].2
uses: google-github-actions/[email protected].3
with:
path: out
glob: '*'
Expand Down
Loading