adjust to new cookie scheme #7946
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -70,6 +70,7 @@ export const KCL_DEFAULT_COLOR = `#3c73ff` | |||
| export const SETTINGS_FILE_NAME = 'settings.toml' | |||
| export const PROJECT_SETTINGS_FILE_NAME = 'project.toml' | |||
| export const COOKIE_NAME = '__Secure-next-auth.session-token' | |||
| export const COOKIE_NAME_DEV = '__Secure-session-token-dev' | |||
There was a problem hiding this comment.
I know this is just a draft, but I don't want to see a literal "dev" propagate any further in this codebase. The term is far too overloaded. 😄
There was a problem hiding this comment.
would preview work? this is mostly targeting api.dev.zoo.dev so not sure what to call it 😓
There was a problem hiding this comment.
I think we want to include the domain of the environment in the cookie name per our discussion on Slack, so something like __secure-session-token-dev.zoo.dev.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for different dev and prod cookie as well as supporting two names for prod cookies