Test fixes following engine zoom fix #8386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jessie Frazelle <[email protected]>
Signed-off-by: Jessie Frazelle <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
jacebrowning
approved these changes
Sep 24, 2025
CodSpeed Instrumentation Performance ReportMerging #8386 will not alter performanceComparing Summary
|
pierremtb
changed the title
6 tasks
pierremtb
commented
Sep 24, 2025
There was a problem hiding this comment.
This snapshot is definitely broken and should also get fixed. It did work at some point in one of the update commits
pierremtb
commented
Sep 24, 2025
| const planeColor: [number, number, number] = [170, 220, 170] | ||
| const bgColor: [number, number, number] = TEST_COLORS.DARK_MODE_BKGD | ||
| const planeColor: [number, number, number] = [80, 60, 60] | ||
| const bgColor: [number, number, number] = [30, 30, 30] |
There was a problem hiding this comment.
This bgColor thing should be reverted but can't afford to wait for another CI run, can do later
pierremtb
commented
Sep 24, 2025
There was a problem hiding this comment.
These snapshots are weird but this is how it shows up in playwright, could be due to a specific cam setup? Unclear
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collection of fixes after https://github.com/KittyCAD/engine/pull/3804 landed:
The few disabled tests to re-enable are tracked at #8382