Set the surface values appropriately for cloned objects #8525
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
CodSpeed Performance ReportMerging #8525 will not alter performanceComparing Summary
Footnotes
|
…eling-app into serena/cloning-set-surfaces
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
…eling-app into serena/cloning-set-surfaces
| exec_state: &mut ExecState, | ||
| args: &Args, | ||
| edge_id: Option<Uuid>, | ||
| clone_id_map: Option<&HashMap<Uuid, Uuid>>, // old sketch id -> new sketch id |
There was a problem hiding this comment.
I don't think the new param is ever passed in.
| Path::Arc { .. } | ||
| | Path::TangentialArc { .. } | ||
| | Path::TangentialArcTo { .. } | ||
| // TODO: (bc) fix me |
There was a problem hiding this comment.
Seems like forgery to sign this as Ben, but I won't stop you 🙂
3 participants
Companion of https://github.com/KittyCAD/engine/pull/3380