Open
Conversation
weissi
reviewed
Nov 18, 2019
Package.swift
Outdated
|
|
||
| import PackageDescription | ||
|
|
||
| #if os(Linux) |
There was a problem hiding this comment.
this change will break cross-compilation. Generally in Package.swift files there should be no #if os(...)/#if arch(...) etc. I think the right change would be to make CLinuxHelpers compile on all OSes by using #if __linux etc in the .c/.h files similar to what SwiftNIO does for its CNIOLinux module: https://github.com/apple/swift-nio/tree/master/Sources/CNIOLinux
Author
There was a problem hiding this comment.
Maybe you are right)
I rollback changes
Author
|
@djones6 can you update snapshot in this repo? |
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am using Kitura-NIO on iOS, and it no need to use CLinuxHelpers on Mac or iOS