Skip to content

re-introduce shutdown fix and bump to async-http-client 1.2.0 #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dannys42 wants to merge 3 commits into
base: master
Choose a base branch
from
+54 −37
Open

re-introduce shutdown fix and bump to async-http-client 1.2.0 #90

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
694959a
re-introduce shutdown fix and bump to async-http-client 1.2.0
Feb 11, 2021
2b9da6c
Update package references for TestServer
Feb 17, 2021
1e9bac4
Tests succeed once again; update CircuitBreaker dependency for Kitura…
dannys42 Jul 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,7 @@ let package = Package(
dependencies: [
.package(url: "https://github.com/Kitura/CircuitBreaker.git", from: "5.0.200"),
.package(url: "https://github.com/Kitura/LoggerAPI.git", from: "1.9.200"),
//.package(url: "https://github.com/swift-server/async-http-client.git", from: "1.2.0"),
.package(url: "https://github.com/swift-server/async-http-client.git", .upToNextMinor(from: "1.1.0")),
.package(url: "https://github.com/swift-server/async-http-client.git", from: "1.2.0"),
],
targets: [
.target(
Expand Down
3 changes: 0 additions & 3 deletions Sources/SwiftyRequest/RestRequest.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,14 +103,11 @@ fileprivate class MutableRequest {
public class RestRequest {

deinit {
/*
if MultiThreadedEventLoopGroup.currentEventLoop != nil {
session.shutdown(){ _ in }
} else {
try? session.syncShutdown()
}
*/
try? session.syncShutdown()
}

/// A default `HTTPClient` instance.
Expand Down