Open
Conversation
Instead of using LongitudeRange,LatitudeRange properties which require knowing the range of the input we use TrimLongitude,TrimLatitude which specify how much to trim at each end of the input interval Hidden cells are used to restrict the mesh shown instead of changing the mesh. This allows us to reuse the VBO when rendering.
Collaborator
Author
|
@jourdain Please review. This is not yet integrated into QuickView. I'll do that starting next Mon. |
jourdain
reviewed
Mar 26, 2026
jourdain
reviewed
Mar 26, 2026
jourdain
reviewed
Mar 26, 2026
| _coords = numpy_support.numpy_to_vtk(outPoints, deep=True) | ||
| outData.GetPoints().SetData(_coords) | ||
| if self.cached_points: | ||
| self.cached_points.Unregister(self) |
Collaborator
There was a problem hiding this comment.
Rather than Unregister, should you just set self.cached_points = None?
Collaborator
Author
There was a problem hiding this comment.
Do I need to do this at all? If the python object is deleted, the c++ object should be unregistered as well, isn't it?
jourdain
reviewed
Mar 26, 2026
jourdain
reviewed
Mar 26, 2026
jourdain
reviewed
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.