DICOM Seg fixes #641
Merged
DICOM Seg fixes #641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
PaulHax
commented
Aug 15, 2024
PaulHax
commented
- wait for full load of SEG DICOM before resampling to parent.
- Follow ITK Z spacing computation method. ITK takes diff between first and last slice, not first and second. Produces slightly different spacing for https://data.kitware.com/#item/66be32b7f87a980650f42292
- Unresolved: SEG DICOM hides ImagePositionPatient tag nested under another tag. This in progress ITK-WASM pipeline would spit out nested tags: dicom sort rebase InsightSoftwareConsortium/ITK-Wasm#1197
|
LGTM! |
floryst
merged commit ff8d9d6
into
simplified-datasource-structure
0 of 3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.