Fixes to allow for native development #125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now it is in the same file as the service it depends on, and the main compose file (docker-compose.yml) can be run by itself.
BryonLewis
approved these changes
Feb 20, 2025
Collaborator
BryonLewis
left a comment
BryonLewis
left a comment
There was a problem hiding this comment.
Just a comment to fully remove 'flower' from the system it isn't needed. You can leave it as is if you want as well. The PR I'm working on removes flower from the system.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came across a couple of issues when setting up native development.
1. Unable to run
docker composewith base compose fileThe
flowerservice defined indocker-compose.ymlis dependent oncelery, which itself is defined indocker-compose.override.yml. This led to errors when runningdocker compose -f ./docker-compose.yml up -das per the native development instructions in the README. This PR movesflowerinto the override file.2. Unable to access
miniofrom localdjangoserverWhile following along with the "native development" instructions in the README, I was unable to access
miniofromdjango, sincedjangowas attempting to reach it atminio:9000. I found that the service was actually reachable atlocalhost:9000, hence the change to.env.docker-compose-native.