Create a slidable ruler for frequency measurements #242
Conversation
naglepuff
changed the title
BryonLewis
left a comment
BryonLewis
left a comment
There was a problem hiding this comment.
Everything functions correctly and the code looks fine to me. My questions/suggestions are mostly some usability things.
There is a bug when swapping between compressed/non-compressed where you don't seem to be able to click to drive until the user toggles the layer on/off again.
I'm wondering if Y-Scaling (shift+scroll wheel) should keep the line at the same position (frequency wise) instead of the KHz changing? If a user places it and wants more details about the pulse by stretching in the Y-Axis it may be nice for the measurement line to stay at the same frequency and just have everything stretch around it.
I added that other PR to give visual feedback of when you can click on the measurement line so there wasn't as much guessing if I was close enough to the line to grab and drag it.
|
@BryonLewis check out the two recent commits, which should address your feedback. |
BryonLewis
left a comment
BryonLewis
left a comment
There was a problem hiding this comment.
Just one minor thing, but everything else looks good.
2 participants
Changes
Adds a new GeoJS layer to the spectrogram viewer that draws a draggable horizontal guide line for more easily eyeballing the minimum frequency of pulses on the spectrogram.
The frequency ruler is turned on/off by a new button above the spectrogram. The button uses the measuring tape icon. When the ruler is enabled, the button will be blue.
When the button is clicked, the ruler will be rendered. Dragging the point along the X-axis will cause the ruler to follow. The text for the frequency will update as the ruler is dragged.
