fix: use root server controller to call rc_area_register #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jourdain
reviewed
Oct 10, 2025
jourdain
reviewed
Oct 10, 2025
jourdain
reviewed
Oct 10, 2025
Collaborator
|
I don't know why the CI failed but I also added more "small" edits for your PR that will make RCA much better. |
Justineantoine
force-pushed
the
fix-register-rca
branch
2 times, most recently
from
6f3ae38 to
0b1b685
Compare
jourdain
reviewed
Oct 13, 2025
Collaborator
|
LGTM |
Justineantoine
force-pushed
the
fix-register-rca
branch
2 times, most recently
from
466dd66 to
1bcc744
Compare
Justineantoine
force-pushed
the
fix-register-rca
branch
from
1bcc744 to
7dc963d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RCA protocol registers
rc_area_registerandrc_area_unregisterin the controller, and as protocols are configured only on the root server it is more accurate to useself.server.root_server.controllerto call these two functions