fix(translator): Apply translation to kwargs passed to state.change callbacks #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jourdain
reviewed
Jan 11, 2024
alesgenova
force-pushed
the
fix-change-translator
branch
from
0287063 to
8395086
Compare
jourdain
reviewed
Jan 12, 2024
| assert b_translator.translate_key("bar") == "b_bar" | ||
| assert b_translator.reverse_translate_key("b_foo") == "foo" | ||
| assert b_translator.reverse_translate_key("b_bar") == "bar" | ||
|
|
Collaborator
There was a problem hiding this comment.
can you test a translator that has prefix+custom-translation?
jourdain
reviewed
Jan 12, 2024
trame_server/state.py
Outdated
| # Execute state listeners | ||
| self._state_listeners.add_all(_keys) | ||
|
|
||
| pushed_state = self.translator.reverse_translate_dict( |
Justineantoine
force-pushed
the
fix-change-translator
branch
3 times, most recently
from
859f7d6 to
4dc096c
Compare
Justineantoine
force-pushed
the
fix-change-translator
branch
from
4dc096c to
ccd987b
Compare
Collaborator
|
I added the translator when registering the callbacks. If the callback is registered by a child server, the main server needs to know how to translate the keys. |
Collaborator
|
is that ok to merge or are you planning to add more tests/or-else? |
Collaborator
|
OK to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.