Skip to content

Conversation

@mwestphal
Copy link
Contributor

@mwestphal mwestphal commented Feb 19, 2025

⚠️ Changes originally introduced through this pull-request have been removed from master by force pushing. Corresponding changes are superseded by #18 ⚠️

Rational:

  • Changes were not ready of integration. To avoid similar issue, we updated the protect-default-branch ruleset to require at least one review. Additionally, we also recommend to mark pull request as draft.

@jcfr jcfr merged commit 97cabc9 into Kitware:master Feb 19, 2025
2 checks passed
@jcfr
Copy link
Collaborator

jcfr commented Feb 19, 2025

Thanks for the contribution 🙏

Note

Squash & Merged using the commit message Chapter8: Update "Unstructured Topology" section to describe vtkPolyhedron

@mwestphal
Copy link
Contributor Author

This was not ready for merge ?

@jcfr
Copy link
Collaborator

jcfr commented Feb 19, 2025

Thanks for the follow-up, I am not sure how to answer the question.

In the future, what do you think of marking pull request requiring additional work as "draft" or "work-in-progress" ?

To avoid similar issue moving forward, I updated the protect-default-branch ruleset to require at least one review before a change can be integrated.

master has been force pushed. If needed, the original changes have been backed-up at https://github.com/jcfr/vtk-book/tree/polyhedron.

My apology for the inconvenience.

@jcfr jcfr changed the title Polyhedron doc Polyhedron doc | ⚠️ Changes removed from master Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants