-
Notifications
You must be signed in to change notification settings - Fork 6
Chapter8: Expand "Unstructured Topology" section with vtkPolyhedron details #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Louis Gombert <[email protected]>
Co-authored-by: Louis Gombert <[email protected]>
Co-authored-by: Louis Gombert <[email protected]>
Co-authored-by: Louis Gombert <[email protected]>
|
@jcfr please review and merge if possible |
|
@jcfr ping |
Co-authored-by: Jean-Christophe Fillion-Robin <[email protected]>
|
@mwestphal Once you confirm the preview (https://vtk-book--18.org.readthedocs.build/en/18/VTKBook/08Chapter8.html) looks good, we will integrate with the following commit message: |
|
For future reference, how did you generate the new and updated figures ? |
I used draw.io, I still have the original files if needed. |
LGTM :) |
Which format are those ? We could also upload them as resource at https://github.com/Kitware/vtk-book/releases/tag/book-resources |
|
@mwestphal It would be nice to show in the new figure that fact that Offsets has m+1 entries, where m is the number of cells. That is, the last entry in the Offsets points to one after the last entry in the Connectivity array. |
https://drive.google.com/file/d/1C_2XBwrTPLR1unhS0spwu90F_znTAwvz/view?usp=drive_link https://drive.google.com/file/d/1SgtBE5GzGSp5_HSq4jMZLrXsxQHG6Bt1/view?usp=sharing Its a propritary format afaics. |
This is already shown. |
where is that? Is it the mCells and kFaces squares? It is not obvious that these are entries and where do they point to? One could think they simply state the number of entries (0 to m-1). |
Yes
They point nowhere Feel free to improve the diagram, links are available above if you want to give it a try. |
That is the problem! They should point to the end of the Connectivity list.
I'll give it a try. |


Uh oh!
There was an error while loading. Please reload this page.