-
Notifications
You must be signed in to change notification settings - Fork 6
Add documentation for global IDs, pedigree IDs, and tangent vectors. #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@jcfr Would you mind reviewing? Do you know if there is a mechanism to keep this repo in sync with the LaTeX version of the book? |
|
+2 |
spyridon97
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you make sure that all these have documentation preferable in the right order?
enum AttributeTypes
{
SCALARS = 0,
VECTORS = 1,
NORMALS = 2,
TCOORDS = 3,
TENSORS = 4,
GLOBALIDS = 5,
PEDIGREEIDS = 6,
EDGEFLAG = 7,
TANGENTS = 8,
RATIONALWEIGHTS = 9,
HIGHERORDERDEGREES = 10,
PROCESSIDS = 11,
NUM_ATTRIBUTES = 12
};
My understanding is that we would "archive" the latex version and move forward with the markdown based on. |
I've made sure they are all present but resisted putting them in the same order as the enumeration. The enumeration developed historically by addition as features were added but many of the attribute types are related to one another and should be discussed together. For example, tangents should appear next to normals and texture coordinates. Similarly, rational weights and higher-order degrees belong together. |
spyridon97
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great ! Thanks for the addition. Feel free to merge.
|
@spyridon97 The issue preventing merging appears to be a bad hook; github never hears back from read-the-docs that the build was successful (but they are happening). @mathstuf was looking into it. |
I will see if I can fix it given my more limited access. |
Thanks! I don't know if they will agree, but I can ask them to reinstate your access if you like. |
|
I found the missing link. I've asked Brad to hook up the app through the kwrobot account. |
|
Now consider integrating using |
@vibraphone Thanks for looking into this. Given the open-source nature of vtk/vtk-book/..., I was a bit surprised to lose access. My guess is that this was an oversight when my org-level admin access was removed without corresponding project/team memberships being granted. To avoid this kind of situation in the future, I’d suggest creating a dedicated GitHub team such as |
No description provided.