Skip to content

Conversation

@vibraphone
Copy link
Member

No description provided.

@vibraphone
Copy link
Member Author

@jcfr Would you mind reviewing? Do you know if there is a mechanism to keep this repo in sync with the LaTeX version of the book?

@spyridon97
Copy link
Collaborator

+2

Copy link
Collaborator

@spyridon97 spyridon97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make sure that all these have documentation preferable in the right order?

enum AttributeTypes
{
SCALARS = 0,
VECTORS = 1,
NORMALS = 2,
TCOORDS = 3,
TENSORS = 4,
GLOBALIDS = 5,
PEDIGREEIDS = 6,
EDGEFLAG = 7,
TANGENTS = 8,
RATIONALWEIGHTS = 9,
HIGHERORDERDEGREES = 10,
PROCESSIDS = 11,
NUM_ATTRIBUTES = 12
};

@jcfr
Copy link
Collaborator

jcfr commented Nov 18, 2025

this repo in sync with the LaTeX version of the book

My understanding is that we would "archive" the latex version and move forward with the markdown based on.

@vibraphone
Copy link
Member Author

Can you make sure that all these have documentation preferable in the right order?

I've made sure they are all present but resisted putting them in the same order as the enumeration. The enumeration developed historically by addition as features were added but many of the attribute types are related to one another and should be discussed together. For example, tangents should appear next to normals and texture coordinates. Similarly, rational weights and higher-order degrees belong together.

Copy link
Collaborator

@spyridon97 spyridon97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great ! Thanks for the addition. Feel free to merge.

@vibraphone
Copy link
Member Author

@spyridon97 The issue preventing merging appears to be a bad hook; github never hears back from read-the-docs that the build was successful (but they are happening). @mathstuf was looking into it.

@jcfr
Copy link
Collaborator

jcfr commented Nov 20, 2025

re: read the docs

I will see if I can fix it given my more limited access.

@vibraphone
Copy link
Member Author

I will see if I can fix it given my more limited access.

Thanks! I don't know if they will agree, but I can ask them to reinstate your access if you like.

@mathstuf
Copy link
Collaborator

I found the missing link. I've asked Brad to hook up the app through the kwrobot account.

@jcfr
Copy link
Collaborator

jcfr commented Nov 20, 2025

Now consider integrating using Squash & Merge 🙏🚀

@jcfr
Copy link
Collaborator

jcfr commented Nov 20, 2025

reinstate your access

@vibraphone Thanks for looking into this. Given the open-source nature of vtk/vtk-book/..., I was a bit surprised to lose access. My guess is that this was an oversight when my org-level admin access was removed without corresponding project/team memberships being granted.

To avoid this kind of situation in the future, I’d suggest creating a dedicated GitHub team such as opensource-external-maintainers and adding external maintainers (like me) there so permissions remain explicit and stable over time.

@vibraphone vibraphone merged commit 57d5b20 into Kitware:master Nov 20, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants