Skip to content

Update packages #2216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 10, 2022
Merged

Update packages #2216

merged 4 commits into from
Jan 10, 2022

Conversation

floryst
Copy link
Contributor

@floryst floryst commented Jan 10, 2022 •
edited
Loading

PR and Code Checklist

  • semantic-release commit messages
  • Run npm run reformat to have correctly formatted code

Context

  • Update dependencies, and update code that is affected by eslint updates and package deprecations.

Changes

  • update dependencies
  • refactor code for eslint
  • BREAKING CHANGE: delete rules-linter.js

Results

  • packages are updated, and new eslint rules are in place

Testing

  • npm build:release, test, and doc work.

@floryst floryst requested a review from jourdain January 10, 2022 18:01
@floryst
Copy link
Contributor Author

floryst commented Jan 10, 2022

I plan on merging #2186 with this one so we can cut a new major release.

jourdain
jourdain approved these changes Jan 10, 2022
View reviewed changes
Copy link
Collaborator

@jourdain jourdain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks for taking care of those dep update...

forrest added 4 commits January 10, 2022 16:27
chore: update packages
de08163 
- None of the breaking changes affect vtk.js.
chore: favor eslint-webpack-plugin
c3a4205 
BREAKING CHANGE: config/rules-linter.js is now gone.
refactor: eslint default case and regex rules
10a6f88
refactor: handle eslint default-param-last cases
d9b32b9 
In all cases, this shouldn't affect the overall API. The changes are
functionally the same, since default parameters only kick in if those
parameters are given "undefined" as their argument.
@floryst floryst merged commit 0df7b50 into master Jan 10, 2022
@floryst floryst deleted the update-packages branch January 10, 2022 21:38
@github-actions
Copy link

🎉 This PR is included in version 22.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Automated label label Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jourdain jourdain jourdain approved these changes

Assignees
No one assigned
Labels
released Automated label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@floryst @jourdain